Skip to content

812 make modifier id unique per modfier#819

Merged
bogadisa merged 17 commits into
mainfrom
812-make-modifier-id-unique-per-modfier
Jun 21, 2026
Merged

812 make modifier id unique per modfier#819
bogadisa merged 17 commits into
mainfrom
812-make-modifier-id-unique-per-modfier

Conversation

@bogadisa

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread src/backend_data_retrieval/data_retrieval_app/external_data_retrieval/config.py Outdated
Comment thread src/backend_api/app/crud/extensions/crud_modifier.py
Comment thread src/frontend/src/store/GraphInputStore.tsx Outdated

@bogadisa bogadisa left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@Ivareh

Ivareh commented Jun 20, 2026

Copy link
Copy Markdown
Member

I fixed in commit e5b04c9

❯ npm run build

> frontend@0.0.0 build
> tsc && vite build

src/components/Graph/CustomTooltip.tsx:4:10 - error TS2305: Module '"recharts"' has no exported member 'TooltipContentProps'.

4 import { TooltipContentProps } from "recharts";
           ~~~~~~~~~~~~~~~~~~~

src/components/Graph/CustomTooltip.tsx:26:20 - error TS2339: Property 'label' does not exist on type 'CustomTooltipProps'.

26   if (typeof props.label == "number") {
                      ~~~~~

src/components/Graph/CustomTooltip.tsx:27:57 - error TS2339: Property 'label' does not exist on type 'CustomTooltipProps'.

27     hoursAgo = getHoursSinceLaunch(currentTime) - props.label;
                                                           ~~~~~

src/components/Graph/CustomTooltip.tsx:37:13 - error TS2339: Property 'active' does not exist on type 'CustomTooltipProps'.

37   if (props.active && props.payload && props.payload.length) {
               ~~~~~~

src/components/Graph/CustomTooltip.tsx:37:29 - error TS2339: Property 'payload' does not exist on type 'CustomTooltipProps'.

37   if (props.active && props.payload && props.payload.length) {
                               ~~~~~~~

src/components/Graph/CustomTooltip.tsx:37:46 - error TS2339: Property 'payload' does not exist on type 'CustomTooltipProps'.

37   if (props.active && props.payload && props.payload.length) {
                                                ~~~~~~~

src/components/Graph/CustomTooltip.tsx:38:30 - error TS2339: Property 'payload' does not exist on type 'CustomTooltipProps'.

38     const confidence = props.payload[0].payload.confidence;
                                ~~~~~~~

src/components/Graph/CustomTooltip.tsx:93:17 - error TS2339: Property 'payload' does not exist on type 'CustomTooltipProps'.

93         {(props.payload[0].value as number) > props.upperBoundry && (
                   ~~~~~~~

src/components/Graph/CustomTooltip.tsx:117:16 - error TS2339: Property 'payload' does not exist on type 'CustomTooltipProps'.

117         {props.payload.map((value, index) => (
                   ~~~~~~~

src/components/Graph/CustomTooltip.tsx:117:29 - error TS7006: Parameter 'value' implicitly has an 'any' type.

117         {props.payload.map((value, index) => (
                                ~~~~~

src/components/Graph/CustomTooltip.tsx:117:36 - error TS7006: Parameter 'index' implicitly has an 'any' type.

117         {props.payload.map((value, index) => (
                                       ~~~~~

src/components/Graph/GraphComponent.tsx:10:3 - error TS2305: Module '"recharts"' has no exported member 'TooltipContentProps'.

10   TooltipContentProps,
     ~~~~~~~~~~~~~~~~~~~


Found 12 errors in 2 files.

Errors  Files
    11  src/components/Graph/CustomTooltip.tsx:4
     1  src/components/Graph/GraphComponent.tsx:10

@bogadisa
bogadisa merged commit 01f8dc4 into main Jun 21, 2026
4 checks passed
@bogadisa
bogadisa deleted the 812-make-modifier-id-unique-per-modfier branch June 21, 2026 17:06
@bogadisa
bogadisa restored the 812-make-modifier-id-unique-per-modfier branch June 21, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make modifier Id unique per modfier

2 participants